[uss_qualifier] authentication validation: don't skip if a scope is missing, improve dependency on current time #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
changed the title
…s are unavailable
Shastick
force-pushed
the
auth-validation-no-skip-missing-scopes
branch
from
fbf42bc to
25b5916
Compare
BenjaminPelletier
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As observed in #690, some deployments under test may not provide scopes for every group of endpoints being tested by the
AuthenticationValidationscenario.This lets the scenario selectively test the endpoints for which scopes are available.
If none of the required scopes are available a
MissingResourceErrorwill be raised at instantiation and the scenario should be reported as skipped.Note that this also moves the instantiation of the validator classes to the moment in time where they are used, as they depend on the current time.